Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New array class #3850

Merged
merged 76 commits into from
Nov 8, 2023
Merged

New array class #3850

merged 76 commits into from
Nov 8, 2023

Conversation

Samuelopez-ansys
Copy link
Member

New array class to control 3DComponent array.

For 2023.2 and previous, most of the properties are retrieved from the AEDT file.

In 2024.1, it will be loaded from a CSV, which is more efficient than saving the full project all the time.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #3850 (b9dc8c6) into main (d6df01f) will increase coverage by 49.82%.
The diff coverage is 97.37%.

@@             Coverage Diff             @@
##             main    #3850       +/-   ##
===========================================
+ Coverage   31.41%   81.24%   +49.82%     
===========================================
  Files         181      182        +1     
  Lines       62376    62681      +305     
===========================================
+ Hits        19597    50925    +31328     
+ Misses      42779    11756    -31023     

pyaedt/hfss.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice implementation. LGTM.
Please check the comment.

pyaedt/modeler/cad/component_array.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous review's changes have been added so not much to say.
As an extra and final remark : I see that you tend to test the input type through isinstance(...,...) calls (e.g. CellArray.is_action = ...). If you want to stick to that approach, I would update the ComponentArray __getitem__ magick method to be consistent.

pyaedt/modeler/cad/component_array.py Outdated Show resolved Hide resolved
pyaedt/modeler/cad/component_array.py Outdated Show resolved Hide resolved
pyaedt/modeler/cad/component_array.py Outdated Show resolved Hide resolved
pyaedt/modeler/cad/component_array.py Outdated Show resolved Hide resolved
pyaedt/modeler/cad/component_array.py Show resolved Hide resolved
pyaedt/modeler/cad/component_array.py Outdated Show resolved Hide resolved
pyaedt/modeler/cad/component_array.py Outdated Show resolved Hide resolved
pyaedt/modeler/cad/component_array.py Show resolved Hide resolved
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) November 8, 2023 09:32
@Samuelopez-ansys Samuelopez-ansys merged commit 70c105a into main Nov 8, 2023
12 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the new_array_class branch November 8, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants