-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New array class #3850
New array class #3850
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov Report
@@ Coverage Diff @@
## main #3850 +/- ##
===========================================
+ Coverage 31.41% 81.24% +49.82%
===========================================
Files 181 182 +1
Lines 62376 62681 +305
===========================================
+ Hits 19597 50925 +31328
+ Misses 42779 11756 -31023 |
Co-authored-by: Kathy Pippert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice implementation. LGTM.
Please check the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My previous review's changes have been added so not much to say.
As an extra and final remark : I see that you tend to test the input type through isinstance(...,...)
calls (e.g. CellArray.is_action = ...
). If you want to stick to that approach, I would update the ComponentArray
__getitem__
magick method to be consistent.
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
New array class to control 3DComponent array.
For 2023.2 and previous, most of the properties are retrieved from the AEDT file.
In 2024.1, it will be loaded from a CSV, which is more efficient than saving the full project all the time.