Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the speed of IL computation in Touchstone parser #3863

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

maxcapodi78
Copy link
Collaborator

on big touchstone files it was taking too much time to compute insertion losses indexes.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #3863 (3f65641) into main (70c105a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3863   +/-   ##
=======================================
  Coverage   81.24%   81.25%           
=======================================
  Files         182      182           
  Lines       62681    62678    -3     
=======================================
  Hits        50927    50927           
+ Misses      11754    11751    -3     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 merged commit c318320 into main Nov 10, 2023
12 checks passed
@maxcapodi78 maxcapodi78 deleted the improve_IL_calculation branch November 10, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants