Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in SweepMaterial creation #3879

Merged
merged 8 commits into from
Nov 16, 2023
Merged

Conversation

Alberto-DM
Copy link
Contributor

Regression in add_material_sweep method in class Materials has been fixed.
Unit tests are improved.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Alberto-DM Alberto-DM enabled auto-merge (squash) November 14, 2023 12:05
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #3879 (0e3085d) into main (67d7ec1) will decrease coverage by 49.88%.
The diff coverage is 3.84%.

❗ Current head 0e3085d differs from pull request most recent head 7efc43a. Consider uploading reports for the commit 7efc43a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3879       +/-   ##
===========================================
- Coverage   81.28%   31.40%   -49.88%     
===========================================
  Files         182      182               
  Lines       62826    62819        -7     
===========================================
- Hits        51069    19731    -31338     
- Misses      11757    43088    +31331     

@Alberto-DM Alberto-DM merged commit e44a1cd into main Nov 16, 2023
10 checks passed
@Alberto-DM Alberto-DM deleted the bugfix_sweepmaterial_creation branch November 16, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants