Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve method get_solution_data to avoid intrinsics as arguments and… #3898

Merged
merged 6 commits into from
Nov 23, 2023

Conversation

maxcapodi78
Copy link
Collaborator

… to add the method to the setups objects

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! It will simplify a lot our lives.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #3898 (b594056) into main (611651b) will decrease coverage by 0.05%.
Report is 2 commits behind head on main.
The diff coverage is 84.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3898      +/-   ##
==========================================
- Coverage   81.30%   81.25%   -0.05%     
==========================================
  Files         182      182              
  Lines       62825    62911      +86     
==========================================
+ Hits        51079    51120      +41     
- Misses      11746    11791      +45     

@maxcapodi78 maxcapodi78 merged commit 69cbff1 into main Nov 23, 2023
10 of 12 checks passed
@maxcapodi78 maxcapodi78 deleted the improve_get_solution_data branch November 23, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants