Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pythoncom issue #3900

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Fix pythoncom issue #3900

merged 5 commits into from
Nov 23, 2023

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Nov 22, 2023

Initializing pythoncom after import.

I have launched all tests locally with COM, and some tests are failing with COM enabled, we should consider adding an "skipif" or fixing the problems. Most of them are in Icepak unit test. But this Pull request does not affect the current performance of PyAEDT with COM.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #3900 (942951a) into main (611651b) will increase coverage by 0.00%.
The diff coverage is 94.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3900   +/-   ##
=======================================
  Coverage   81.30%   81.30%           
=======================================
  Files         182      182           
  Lines       62825    62787   -38     
=======================================
- Hits        51079    51050   -29     
+ Misses      11746    11737    -9     

@maxcapodi78 maxcapodi78 merged commit d028e5f into main Nov 23, 2023
12 checks passed
@maxcapodi78 maxcapodi78 deleted the fix_pythoncom_issue branch November 23, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants