Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solder balls height control with simconfig #3905

Merged
merged 34 commits into from
Nov 24, 2023

Conversation

svandenb-dev
Copy link
Collaborator

Adding custom solder balls height support with SImulatiomCnnfiguration class.

# Conflicts:
#	pyaedt/edb_core/edb_data/primitives_data.py
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #3905 (3f0eb57) into main (2ba12b5) will increase coverage by 0.00%.
The diff coverage is 94.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3905   +/-   ##
=======================================
  Coverage   81.29%   81.30%           
=======================================
  Files         182      182           
  Lines       63022    63030    +8     
=======================================
+ Hits        51234    51245   +11     
+ Misses      11788    11785    -3     

Copy link
Contributor

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codecov seems to indicate that the modified method build_simulation_project is not tested for dict components. When I read the code, I feel like it should be done with your new test and json file. Can you double check that your test works fine ?

pyaedt/edb.py Show resolved Hide resolved
@svandenb-dev svandenb-dev merged commit 09db4b3 into main Nov 24, 2023
12 checks passed
@svandenb-dev svandenb-dev deleted the solder_balls_height_control_with_simconfig branch November 24, 2023 12:29
@svandenb-dev svandenb-dev restored the solder_balls_height_control_with_simconfig branch November 24, 2023 12:33
@Samuelopez-ansys Samuelopez-ansys deleted the solder_balls_height_control_with_simconfig branch August 9, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom solder balls height with SimulationConfiguration class
4 participants