-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve variations in create_report #3924
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We will need to cover more cases in another pull request (like domain = "Time")
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3924 +/- ##
==========================================
+ Coverage 81.29% 81.30% +0.01%
==========================================
Files 182 182
Lines 63037 63042 +5
==========================================
+ Hits 51247 51258 +11
+ Misses 11790 11784 -6 |
Hello All, I just wanted to point out that the primary sweep is not a variation. Variation for me is when you add any variable and define a sweep for this variable in optimetrics. A variation will be specified with a corresponding primary sweep. |
@amichel0205 Talk with AEDT API development, this is the behavior since AEDT API exists :) |
At the moment if variations is not provided as input to the method and there are no available variations in the design, report is empty.