Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve variations in create_report #3924

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

gmalinve
Copy link
Collaborator

At the moment if variations is not provided as input to the method and there are no available variations in the design, report is empty.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Nov 29, 2023
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We will need to cover more cases in another pull request (like domain = "Time")

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #3924 (bdf00b3) into main (8f38bd0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3924      +/-   ##
==========================================
+ Coverage   81.29%   81.30%   +0.01%     
==========================================
  Files         182      182              
  Lines       63037    63042       +5     
==========================================
+ Hits        51247    51258      +11     
+ Misses      11790    11784       -6     

@amichel0205
Copy link
Collaborator

Hello All,

I just wanted to point out that the primary sweep is not a variation. Variation for me is when you add any variable and define a sweep for this variable in optimetrics. A variation will be specified with a corresponding primary sweep.
So I can't tell the consequence of considering the primary sweep as a variation but I just wanted to share my thought.

@Samuelopez-ansys
Copy link
Member

@amichel0205 Talk with AEDT API development, this is the behavior since AEDT API exists :)

@gmalinve gmalinve linked an issue Nov 29, 2023 that may be closed by this pull request
@gmalinve gmalinve merged commit 62b6750 into main Nov 29, 2023
12 checks passed
@gmalinve gmalinve deleted the fix_variations_create_report branch November 29, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve variations in create_report for domain "Sweep"
3 participants