-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix KeyError
in enable_adaptive_setup_multifrequency
#3930
Merged
Samuelopez-ansys
merged 9 commits into
ansys:main
from
atlanswer:fix-enable-adaptive-setup-multifrequency
Nov 30, 2023
Merged
Fix KeyError
in enable_adaptive_setup_multifrequency
#3930
Samuelopez-ansys
merged 9 commits into
ansys:main
from
atlanswer:fix-enable-adaptive-setup-multifrequency
Nov 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: case for using auto-open region
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3930 +/- ##
==========================================
- Coverage 81.31% 81.31% -0.01%
==========================================
Files 182 182
Lines 63051 63051
==========================================
- Hits 51268 51267 -1
- Misses 11783 11784 +1 |
Samuelopez-ansys
approved these changes
Nov 30, 2023
MaxJPRey
reviewed
Nov 30, 2023
MaxJPRey
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Co-authored-by: Maxime Rey <[email protected]>
Samuelopez-ansys
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
props["MultipleAdaptiveFreqsSetup"]
could potentially be nonexistent.A known case is the setup automatically created by setting auto-open region.
Related test case added.