Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeyError in enable_adaptive_setup_multifrequency #3930

Merged

Conversation

atlanswer
Copy link
Contributor

props["MultipleAdaptiveFreqsSetup"] could potentially be nonexistent.
A known case is the setup automatically created by setting auto-open region.
Related test case added.

test: case for using auto-open region
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #3930 (00df959) into main (ba5169b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3930      +/-   ##
==========================================
- Coverage   81.31%   81.31%   -0.01%     
==========================================
  Files         182      182              
  Lines       63051    63051              
==========================================
- Hits        51268    51267       -1     
- Misses      11783    11784       +1     

pyaedt/modules/SolveSetup.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Samuelopez-ansys Samuelopez-ansys merged commit dc75b24 into ansys:main Nov 30, 2023
10 of 11 checks passed
@atlanswer atlanswer deleted the fix-enable-adaptive-setup-multifrequency branch November 30, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants