Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netlist issues #3938

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Fix netlist issues #3938

merged 4 commits into from
Dec 4, 2023

Conversation

Samuelopez-ansys
Copy link
Member

Allow parameter with and without =
Allow µ

Allow parameter with and without =
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #3938 (6b76517) into main (4f64da5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3938      +/-   ##
==========================================
+ Coverage   81.31%   81.33%   +0.01%     
==========================================
  Files         182      182              
  Lines       63060    63069       +9     
==========================================
+ Hits        51279    51295      +16     
+ Misses      11781    11774       -7     

Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 merged commit 22fefda into main Dec 4, 2023
12 checks passed
@maxcapodi78 maxcapodi78 deleted the fix_netlist_creation branch December 4, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants