Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix on Surface material creation and value_with_units #3942

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

Alberto-DM
Copy link
Contributor

  • added "PhysicsTypes" property on Surface material creation.
  • fixed value_with_units in case units=""

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #3942 (c08f57f) into main (4f64da5) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3942   +/-   ##
=======================================
  Coverage   81.31%   81.32%           
=======================================
  Files         182      182           
  Lines       63060    63070   +10     
=======================================
+ Hits        51279    51293   +14     
+ Misses      11781    11777    -4     

@maxcapodi78 maxcapodi78 merged commit 44ae3d4 into main Dec 4, 2023
12 checks passed
@maxcapodi78 maxcapodi78 deleted the bug_surfacematerial_physic-type branch December 4, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants