Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve desktop launch #3947

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Improve desktop launch #3947

merged 5 commits into from
Dec 6, 2023

Conversation

Alberto-DM
Copy link
Contributor

@Alberto-DM Alberto-DM commented Dec 5, 2023

AEDT process would block GRPC communication with the main thread when AEDT is busy.
This fix in desktop launch method solves this problem.
Other changes in this PR:

  • normalize_vector now support null vector [0,0,0]
  • import_nastran improvements for speed
  • removed unnecessary operation with units in add_variation

maxcapodi78 and others added 4 commits December 5, 2023 10:53
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #3947 (cdbcf37) into main (3376ce9) will increase coverage by 0.00%.
The diff coverage is 91.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3947   +/-   ##
=======================================
  Coverage   81.34%   81.35%           
=======================================
  Files         182      182           
  Lines       63143    63147    +4     
=======================================
+ Hits        51366    51375    +9     
+ Misses      11777    11772    -5     

@Alberto-DM Alberto-DM merged commit 223399e into main Dec 6, 2023
12 checks passed
@Alberto-DM Alberto-DM deleted the improve_desktop_launch branch December 6, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants