Replace all os.name with boolean checks is_windows, is_linux #3956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3956 +/- ##
=======================================
Coverage 81.34% 81.35%
=======================================
Files 182 182
Lines 63130 63132 +2
=======================================
+ Hits 51353 51360 +7
+ Misses 11777 11772 -5 |
|
@kbhagat-ansys From which AEDT version is available libPyDesktopPlugin.so? @maxcapodi78 Any comments? |
Samuelopez-ansys
approved these changes
Dec 13, 2023
kbhagat-ansys
deleted the
2688-replace-all-osname-checks-with-is_windows-is_linux-booleans
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #2688