Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edb sip format import added #3959

Merged
merged 33 commits into from
Dec 13, 2023
Merged

Edb sip format import added #3959

merged 33 commits into from
Dec 13, 2023

Conversation

svandenb-dev
Copy link
Collaborator

No description provided.

# Conflicts:
#	pyaedt/edb_core/edb_data/primitives_data.py
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@svandenb-dev svandenb-dev linked an issue Dec 11, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #3959 (c96e835) into main (3664c1b) will decrease coverage by 0.01%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3959      +/-   ##
==========================================
- Coverage   81.36%   81.36%   -0.01%     
==========================================
  Files         182      182              
  Lines       63179    63142      -37     
==========================================
- Hits        51405    51374      -31     
+ Misses      11774    11768       -6     

Copy link
Contributor

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 1a4f264 into main Dec 13, 2023
12 checks passed
@svandenb-dev svandenb-dev deleted the edb_sip_format_import_added branch December 13, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EDB - support sip file extension with EDB class instance
2 participants