Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New conducting plate function #3980

Merged
merged 15 commits into from
Dec 15, 2023
Merged

New conducting plate function #3980

merged 15 commits into from
Dec 15, 2023

Conversation

lorenzovecchietti
Copy link
Contributor

@lorenzovecchietti lorenzovecchietti commented Dec 13, 2023

Close #3979

Add new function to assign conducting plate boundary condition. Deprecated the old one.
Advantages of the new one:

  1. less inputs needed
  2. coherency with all the other bc function for icepak
  3. now supports transient assignment

Auxiliary functions added.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review December 13, 2023 16:29
@lorenzovecchietti lorenzovecchietti marked this pull request as draft December 13, 2023 16:30
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #3980 (14cc145) into main (d764caa) will increase coverage by 0.00%.
The diff coverage is 97.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3980   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files         182      182           
  Lines       63160    63202   +42     
=======================================
+ Hits        51400    51438   +38     
- Misses      11760    11764    +4     

@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review December 13, 2023 17:00
pyaedt/icepak.py Outdated Show resolved Hide resolved
pyaedt/icepak.py Outdated Show resolved Hide resolved
pyaedt/icepak.py Outdated Show resolved Hide resolved
@lorenzovecchietti lorenzovecchietti merged commit bf1a275 into main Dec 15, 2023
12 checks passed
@lorenzovecchietti lorenzovecchietti deleted the enhancement/plates branch December 15, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve conducting plane boundary condition
3 participants