Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core loss example #3997

Merged
merged 14 commits into from
Dec 22, 2023
Merged

core loss example #3997

merged 14 commits into from
Dec 22, 2023

Conversation

gmalinve
Copy link
Collaborator

No description provided.

@gmalinve gmalinve self-assigned this Dec 20, 2023
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gmalinve gmalinve linked an issue Dec 20, 2023 that may be closed by this pull request
add set_coreloss_at_frequency and get_coreloss_at_freq in example #3967
Closed
@gmalinve gmalinve mentioned this pull request Dec 20, 2023
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (39707fd) 81.42% compared to head (0a33ad5) 78.81%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3997      +/-   ##
==========================================
- Coverage   81.42%   78.81%   -2.61%     
==========================================
  Files         182      182              
  Lines       63292    63306      +14     
==========================================
- Hits        51533    49895    -1638     
- Misses      11759    13411    +1652

@gmalinve gmalinve requested review from SMoraisAnsys and removed request for Alberto-DM and MaxJPRey December 20, 2023 15:19
SMoraisAnsys
SMoraisAnsys requested changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some changes I would suggest.

_unittest/test_03_Materials.py Outdated Show resolved Hide resolved
pyaedt/modules/Material.py Outdated Show resolved Hide resolved
pyaedt/modules/Material.py Outdated Show resolved Hide resolved
pyaedt/modules/Material.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Dec 21, 2023
View reviewed changes
_unittest/test_20_HFSS.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Dec 21, 2023
View reviewed changes
_unittest/test_20_HFSS.py Outdated Show resolved Hide resolved
Samuelopez-ansys
Samuelopez-ansys approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 0e2e1c2 into main Dec 22, 2023
12 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the coreloss_at_freq_example branch December 22, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

@tizianrot tizianrot Awaiting requested review from tizianrot

@IreneWoyna IreneWoyna Awaiting requested review from IreneWoyna

Assignees

@gmalinve gmalinve

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add set_coreloss_at_frequency and get_coreloss_at_freq in example
4 participants
@gmalinve @PipKat @Samuelopez-ansys @SMoraisAnsys