Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use empty list as default parameter value. #4004

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Conversation

MaxJPRey
Copy link
Collaborator

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance Package and maintenance related label Dec 21, 2023
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9f2c09f) 81.41% compared to head (b52f1d7) 81.39%.

❗ Current head b52f1d7 differs from pull request most recent head 53f9f56. Consider uploading reports for the commit 53f9f56 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4004      +/-   ##
==========================================
- Coverage   81.41%   81.39%   -0.03%     
==========================================
  Files         182      182              
  Lines       63286    63217      -69     
==========================================
- Hits        51523    51454      -69     
  Misses      11763    11763              

pyaedt/downloads.py Outdated Show resolved Hide resolved
@MaxJPRey MaxJPRey enabled auto-merge (squash) December 21, 2023 16:52
@MaxJPRey MaxJPRey merged commit 709cc06 into main Dec 21, 2023
11 checks passed
@MaxJPRey MaxJPRey deleted the maint/default_list branch December 21, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants