-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New pdf report #4030
New pdf report #4030
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4030 +/- ##
==========================================
+ Coverage 81.42% 81.46% +0.04%
==========================================
Files 182 182
Lines 63380 63565 +185
==========================================
+ Hits 51607 51784 +177
- Misses 11773 11781 +8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job with this refactoring ! I do have a warning to raise and a couple of minor changes.
Warning: you use f-strings (which is nice) but I don't know if this feature should be used by our IronPython users. If that's the case, you should this and use str format
to be compatible. If that's not the case, I would recommend using dataclasses
for the classes at the beginning of the file pdf.py. That would make total sense here and you could just use MyDataClass(**kwargs)
.
Minor changes:
- use private method and attribute instead of protected (
__
vs_
) except for self._outline which comes fromFPDF
; - move import at the begining of a function
Co-authored-by: SMoraisAnsys <[email protected]>
for more information, see https://pre-commit.ci
Merged templatedata and ReportSpecs into a single data class
# Conflicts: # pyaedt/generic/pdf.py
Merged templatedata and ReportSpecs into a single data class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great! It is worth adding it somewhere in the documentation for better feature visibility.
Entirely based on Python