-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path length correction #4035
Path length correction #4035
Conversation
# Conflicts: # pyaedt/edb_core/edb_data/primitives_data.py
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4035 +/- ##
==========================================
+ Coverage 81.40% 81.47% +0.06%
==========================================
Files 182 182
Lines 63398 63569 +171
==========================================
+ Hits 51612 51793 +181
+ Misses 11786 11776 -10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adjusting path length computation with taking in account arcs and cap end style. Values has been compared with the one from aedt and both are matching.