Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path length correction #4035

Merged
merged 37 commits into from
Jan 9, 2024
Merged

Path length correction #4035

merged 37 commits into from
Jan 9, 2024

Conversation

svandenb-dev
Copy link
Collaborator

Adjusting path length computation with taking in account arcs and cap end style. Values has been compared with the one from aedt and both are matching.

# Conflicts:
#	pyaedt/edb_core/edb_data/primitives_data.py
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@svandenb-dev svandenb-dev self-assigned this Jan 8, 2024
@svandenb-dev svandenb-dev linked an issue Jan 8, 2024 that may be closed by this pull request
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df687f7) 81.40% compared to head (6051a59) 81.47%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4035      +/-   ##
==========================================
+ Coverage   81.40%   81.47%   +0.06%     
==========================================
  Files         182      182              
  Lines       63398    63569     +171     
==========================================
+ Hits        51612    51793     +181     
+ Misses      11786    11776      -10     

Copy link
Collaborator

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 2c1d8e7 into main Jan 9, 2024
15 checks passed
@svandenb-dev svandenb-dev deleted the path_length_correction branch January 9, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path length computation accuracy improvement
3 participants