Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component is top #4052

Merged
merged 44 commits into from
Jan 10, 2024
Merged

Component is top #4052

merged 44 commits into from
Jan 10, 2024

Conversation

svandenb-dev
Copy link
Collaborator

Component.is_top property added.

# Conflicts:
#	pyaedt/edb_core/edb_data/primitives_data.py
@svandenb-dev svandenb-dev added enhancement New features or code improvements edb labels Jan 9, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@svandenb-dev svandenb-dev linked an issue Jan 9, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c1de513) 81.64% compared to head (c97b54b) 31.16%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4052       +/-   ##
===========================================
- Coverage   81.64%   31.16%   -50.49%     
===========================================
  Files         182      182               
  Lines       63537    63552       +15     
===========================================
- Hits        51876    19803    -32073     
- Misses      11661    43749    +32088     

@svandenb-dev svandenb-dev enabled auto-merge (squash) January 10, 2024 14:50
@svandenb-dev svandenb-dev merged commit 48a05b8 into main Jan 10, 2024
14 checks passed
@svandenb-dev svandenb-dev deleted the component_is_top branch January 10, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding component.is_top property
3 participants