CI: Refact and extend CI/CD workflows to leverage ansys actions #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Note: this job uses Make target html-noexamples
Note: targets have been added and refactored.
Note: this new environment variable is used to decide whether the examples are included in the documentation build or not.
SMoraisAnsys
force-pushed
the
ci/refact_cicd
branch
from
f806488
to
969d5df
Compare
github-actions
bot
added
documentation
maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4284 +/- ##
==========================================
+ Coverage 81.73% 81.74% +0.01%
==========================================
Files 107 107
Lines 51788 51788
==========================================
+ Hits 42328 42334 +6
+ Misses 9460 9454 -6 |
This reverts commit f733aca.
Note: Modify job name and use "env" instead of settings them from commands.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4284 +/- ##
==========================================
+ Coverage 81.48% 81.59% +0.11%
==========================================
Files 110 111 +1
Lines 53887 53948 +61
==========================================
+ Hits 43908 44019 +111
+ Misses 9979 9929 -50 |
Note: This will bundle the packages required to run the examples and other packages that are often used with pyaedt
This reverts commit f733aca.
Changes include: - reworking the way HTML pages are created (with/without examples) - adding clean target - refact pdf target
Note: Json code block do not accept comments with hashtag
|
@Samuelopez-ansys FYI there was still some issues with our self hosted runners and I had to make a few changes in them. Hoperfully this will lead us to a working PDF with examples 🤞 |
Co-authored-by: Kathy Pippert <[email protected]>
SMoraisAnsys
commented
Apr 30, 2024
|
@Samuelopez-ansys The PR is ready to be merged ! |
Samuelopez-ansys
previously approved these changes
Apr 30, 2024
This was referenced May 2, 2024
Closed
|
Thanks @SMoraisAnsys . Great work that would be extremely valuable for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
One of the new steps requires that a new
ansys/actionsis released. This PR shouldn't be merged as long as5.1.9is the latest version released.List of the worfklows to validate in the new one (aggregation into one workflow):
-Wwhen building documentation with sphinx-build #4296if we keep print_errors.py or leverage option)-Wofsphinx-build, or something elseExtra workflows:
[Nightly] Cpython linux (test and test solver)[Nightly] Doc build with upload and update dev index