Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Toolkit installer #4593

Merged
merged 57 commits into from
May 3, 2024
Merged

FEAT: Toolkit installer #4593

merged 57 commits into from
May 3, 2024

Conversation

Samuelopez-ansys
Copy link
Member

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Samuelopez-ansys
Copy link
Member Author

New toolkit manager and new PyAEDT installation style:
image
The toolkit manager allows to install PyAEDT script in AEDT and also open source toolkits (like the Antenna Wizard)

@github-actions github-actions bot added the enhancement New features or code improvements label Apr 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.86491% with 450 lines in your changes are missing coverage. Please review.

Project coverage is 80.77%. Comparing base (9c4ba60) to head (554d9a0).
Report is 1 commits behind head on main.

❗ Current head 554d9a0 differs from pull request most recent head b16e811. Consider uploading reports for the commit b16e811 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4593      +/-   ##
==========================================
- Coverage   81.48%   80.77%   -0.71%     
==========================================
  Files         110      117       +7     
  Lines       53887    54462     +575     
==========================================
+ Hits        43908    43992      +84     
- Misses       9979    10470     +491

@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft April 26, 2024 14:04
@Samuelopez-ansys Samuelopez-ansys marked this pull request as ready for review May 3, 2024 11:09
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) May 3, 2024 15:50
maxcapodi78
maxcapodi78 approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Killing Feature

@Samuelopez-ansys Samuelopez-ansys merged commit 22a1fb5 into main May 3, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/toolkit_installer branch May 3, 2024 16:31
@Samuelopez-ansys Samuelopez-ansys linked an issue May 6, 2024 that may be closed by this pull request
Create a toolkit manager #4638
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhagat-ansys kbhagat-ansys kbhagat-ansys left review comments

@PipKat PipKat PipKat left review comments

@maxcapodi78 maxcapodi78 maxcapodi78 approved these changes

@Devin-Crawford Devin-Crawford Awaiting requested review from Devin-Crawford

@gmalinve gmalinve Awaiting requested review from gmalinve

@SMoraisAnsys SMoraisAnsys Awaiting requested review from SMoraisAnsys

Assignees
No one assigned
Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a toolkit manager
5 participants
@Samuelopez-ansys @codecov-commenter @maxcapodi78 @kbhagat-ansys @PipKat