Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Method get_obj_material #4603

Merged
merged 2 commits into from
Apr 30, 2024
Merged

FIX: Method get_obj_material #4603

merged 2 commits into from
Apr 30, 2024

Conversation

gmalinve
Copy link
Collaborator

No description provided.

@gmalinve gmalinve self-assigned this Apr 29, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Apr 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.50%. Comparing base (7832843) to head (96d4043).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4603      +/-   ##
==========================================
- Coverage   81.52%   81.50%   -0.03%     
==========================================
  Files         110      110              
  Lines       53772    53845      +73     
==========================================
+ Hits        43838    43886      +48     
- Misses       9934     9959      +25     

MaxJPRey
MaxJPRey previously approved these changes Apr 30, 2024
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SMoraisAnsys SMoraisAnsys marked this pull request as draft April 30, 2024 08:10
@SMoraisAnsys
Copy link
Collaborator

The changes proposed here are an attempt to fix the CI failure in ansys/magnet-segmentation-toolkit#193 that is supposed to be related to the recent changes in get_objects_by_material.

@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review April 30, 2024 08:37
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SMoraisAnsys SMoraisAnsys changed the title fix get_obj_material FIX: Method get_obj_material Apr 30, 2024
@Samuelopez-ansys Samuelopez-ansys merged commit 388de1d into main Apr 30, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/get_obj_material branch April 30, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants