Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: add options for fieldplot image export #4605

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

lorenzovecchietti
Copy link
Contributor

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review April 30, 2024 07:17
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is just a tiny typo in the docstring.

pyaedt/modules/solutions.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.41%. Comparing base (7832843) to head (ffddb1d).
Report is 28 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4605       +/-   ##
===========================================
- Coverage   81.52%   34.41%   -47.11%     
===========================================
  Files         110      110               
  Lines       53772    53841       +69     
===========================================
- Hits        43838    18530    -25308     
- Misses       9934    35311    +25377     

@SMoraisAnsys
Copy link
Collaborator

@lorenzovecchietti I took the liberty of performing the changes I requested as they were clearly a left typo.

@lorenzovecchietti lorenzovecchietti enabled auto-merge (squash) April 30, 2024 08:10
@lorenzovecchietti lorenzovecchietti merged commit 0235765 into main Apr 30, 2024
15 checks passed
@lorenzovecchietti lorenzovecchietti deleted the enhance-fieldplot-export branch April 30, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants