Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Issue launch toolkit from aedt #4652

Merged
merged 15 commits into from
May 10, 2024

Conversation

Samuelopez-ansys
Copy link
Member

Use RunProgram instead of subprocess

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft May 8, 2024 10:21
@github-actions github-actions bot added the bug Something isn't working label May 8, 2024
@Samuelopez-ansys
Copy link
Member Author

This PR also add:

  • When the PyAEDT installer script is launched from a non graphical AEDT, it will crash if the Message Box appears, now we check if AEDT is launched in graphical mode.
  • In the toolkit manager, if the user does not pass any script in the "Custom" option, it will create an script with the template needed to create a basic workflow.

@Samuelopez-ansys Samuelopez-ansys changed the title Fix/issue launch toolkit from aedt FIX : Issue launch toolkit from aedt May 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 80.80%. Comparing base (bd9d18c) to head (c798e1a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4652      +/-   ##
==========================================
- Coverage   80.84%   80.80%   -0.04%     
==========================================
  Files         119      120       +1     
  Lines       54542    54559      +17     
==========================================
- Hits        44093    44087       -6     
- Misses      10449    10472      +23     

@Samuelopez-ansys Samuelopez-ansys changed the title FIX : Issue launch toolkit from aedt REFACTOR: Issue launch toolkit from aedt May 8, 2024
@Samuelopez-ansys Samuelopez-ansys marked this pull request as ready for review May 9, 2024 10:22
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) May 10, 2024 13:51
@Samuelopez-ansys Samuelopez-ansys merged commit e6784e5 into main May 10, 2024
30 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/issue_launch_toolkit_from_aedt branch May 10, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants