-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR: Architecture to match pyansys guide lines #4849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This is required to allow installing the package and using it though 'pyaedt' and 'ansys.aedt.core'
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
maintenance
Package and maintenance related
examples
Anything related to the examples
documentation
Improvements or additions to documentation
testing
Anything related to testing
labels
Jun 25, 2024
Co-authored-by: Samuel Lopez <[email protected]>
Co-authored-by: Samuel Lopez <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4849 +/- ##
==========================================
- Coverage 83.51% 82.87% -0.64%
==========================================
Files 122 124 +2
Lines 54975 55417 +442
==========================================
+ Hits 45910 45925 +15
- Misses 9065 9492 +427 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Samuelopez-ansys
previously approved these changes
Aug 16, 2024
SMoraisAnsys
requested review from
jsalant22,
myoung301,
MaxJPRey and
maxcapodi78
as code owners
August 16, 2024 13:20
myoung301
reviewed
Aug 16, 2024
Co-authored-by: Matthew Young <[email protected]>
Samuelopez-ansys
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
examples
Anything related to the examples
maintenance
Package and maintenance related
testing
Anything related to testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a huge refactoring of the code base. It includes the following changes:
pyaedt
tosrc/ansys/aedt/core
;src/ansys/aedt/core
insrc/pyaedt
to allow users to keep being able to doimport pyaedt
;flint
tosetuptools
to allow building while having 2. working correctly (otherwise, only one target can be used)Note: a warning is now triggered when one does
import pyaedt
so that every user is aware of this changes. On top of that, the renaming of the files shouldn't be impacting users as we are doing 2 and 4 at the same time. This way, old filenmaes will temporarily remain available as aliases pointing to the newly renamed files, ensuring temporary backward compatibility.