Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Architecture to match pyansys guide lines #4849

Merged
merged 47 commits into from
Aug 16, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Jun 25, 2024

This PR is a huge refactoring of the code base. It includes the following changes:

  1. move the code from pyaedt to src/ansys/aedt/core;
  2. duplicate the files of src/ansys/aedt/core in src/pyaedt to allow users to keep being able to do import pyaedt;
  3. rename files to follow PEP8 convention on module names and harmonize with other python files;
  4. change build system from flint to setuptools to allow building while having 2. working correctly (otherwise, only one target can be used)

Note: a warning is now triggered when one does import pyaedt so that every user is aware of this changes. On top of that, the renaming of the files shouldn't be impacting users as we are doing 2 and 4 at the same time. This way, old filenmaes will temporarily remain available as aliases pointing to the newly renamed files, ensuring temporary backward compatibility.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added maintenance Package and maintenance related examples Anything related to the examples documentation Improvements or additions to documentation testing Anything related to testing labels Jun 25, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 97.74127% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.87%. Comparing base (ca17b80) to head (1b49936).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4849      +/-   ##
==========================================
- Coverage   83.51%   82.87%   -0.64%     
==========================================
  Files         122      124       +2     
  Lines       54975    55417     +442     
==========================================
+ Hits        45910    45925      +15     
- Misses       9065     9492     +427     

@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review August 16, 2024 13:20
.gitignore Outdated Show resolved Hide resolved
Co-authored-by: Matthew Young <[email protected]>
@SMoraisAnsys SMoraisAnsys merged commit cbad1a0 into main Aug 16, 2024
40 of 42 checks passed
@SMoraisAnsys SMoraisAnsys deleted the refact/architecture branch August 16, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation examples Anything related to the examples maintenance Package and maintenance related testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants