REFACTOR: Icepak Mesh class initialization performance #4877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4877 +/- ##
==========================================
+ Coverage 83.16% 83.18% +0.02%
==========================================
Files 118 118
Lines 54143 54140 -3
==========================================
+ Hits 45027 45036 +9
+ Misses 9116 9104 -12 |
lorenzovecchietti
requested review from
siva-krishnaswamy,
nnetake and
SMoraisAnsys
|
@SMoraisAnsys I excluded from test coverage the lines of code that are related to 23R2 and previous, but is seems that codecov is ignoring the |
SMoraisAnsys
reviewed
Jul 8, 2024
There was a problem hiding this comment.
@lorenzovecchietti It might be related with the extra space used to declare the code a not covered. Can you try the proposed changes ?
lorenzovecchietti
dismissed stale reviews from siva-krishnaswamy and nnetake
via
d90877d
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
lorenzovecchietti
requested review from
siva-krishnaswamy,
nnetake and
SMoraisAnsys
MaxJPRey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4876
Big thanks to @Leunamedaking for the help in testing the changes.