-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUILD: Remove imageio from requirements #4905
Conversation
added environment variable in linux extension
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, imageio was probably missed when extracting pyedb from pyaedt !
Are the linux changes related to an issue or something ? Why are they needed ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4905 +/- ##
==========================================
- Coverage 83.18% 83.17% -0.01%
==========================================
Files 118 118
Lines 54147 54177 +30
==========================================
+ Hits 45041 45064 +23
- Misses 9106 9113 +7 |
@SMoraisAnsys Yes. I' didn't enter the issue. I've tested yesterday on our Cluster and it happens that if I open AEDT from SLURM or LSF and then launch the console the variables are obviously not there. So I force the add of the variable before initializing the pyaedt console |
@maxcapodi78 In fact, can you update the pyproject.toml file so that we use |
added environment variable in linux extension.
Close #4909