Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD: Remove imageio from requirements #4905

Merged
merged 3 commits into from
Jul 12, 2024
Merged

BUILD: Remove imageio from requirements #4905

merged 3 commits into from
Jul 12, 2024

Conversation

maxcapodi78
Copy link
Collaborator

@maxcapodi78 maxcapodi78 commented Jul 11, 2024

added environment variable in linux extension.
Close #4909

added environment variable in linux extension
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added maintenance Package and maintenance related bug Something isn't working labels Jul 11, 2024
SMoraisAnsys
SMoraisAnsys previously approved these changes Jul 11, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, imageio was probably missed when extracting pyedb from pyaedt !

@SMoraisAnsys
Copy link
Collaborator

Are the linux changes related to an issue or something ? Why are they needed ?

@SMoraisAnsys SMoraisAnsys changed the title removed imageio from requirements. BUILD: Remove imageio from requirements Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.17%. Comparing base (f541b56) to head (7e6ab04).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4905      +/-   ##
==========================================
- Coverage   83.18%   83.17%   -0.01%     
==========================================
  Files         118      118              
  Lines       54147    54177      +30     
==========================================
+ Hits        45041    45064      +23     
- Misses       9106     9113       +7     

@maxcapodi78
Copy link
Collaborator Author

Are the linux changes related to an issue or something ? Why are they needed ?

@SMoraisAnsys Yes. I' didn't enter the issue. I've tested yesterday on our Cluster and it happens that if I open AEDT from SLURM or LSF and then launch the console the variables are obviously not there. So I force the add of the variable before initializing the pyaedt console

@SMoraisAnsys
Copy link
Collaborator

Seems like imageio is required by pyvista and some test with animated plots are failing.

image

Can you update the PR title to match linux changes and add a comment on imageio in pyproject.toml so that we remember the reason for this requirement ?

@SMoraisAnsys
Copy link
Collaborator

@maxcapodi78 In fact, can you update the pyproject.toml file so that we use pyvista[io] (https://github.com/pyvista/pyvista/blob/main/pyproject.toml#L46)

@maxcapodi78 maxcapodi78 merged commit 7c13558 into main Jul 12, 2024
46 checks passed
@maxcapodi78 maxcapodi78 deleted the fix_toml branch July 12, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in AEDT Ribbon Bar
2 participants