FEAT: set thermal modifier and spatial modifier to None #4908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to None - fix: when setting the thermalmodifier and spatialmodifier properties, the matarial was changed properly, but PyAEDT property did not show the change. - fix: if the thermal or spatial modifier was set to None (EITHER in the UI or in PyAEDT), further changes in the property modifiers would be ignored.
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Alberto-DM
requested review from
maxcapodi78
and removed request for
Samuelopez-ansys
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4908 +/- ##
==========================================
- Coverage 83.18% 83.18% -0.01%
==========================================
Files 118 118
Lines 54147 54177 +30
==========================================
+ Hits 45041 45065 +24
- Misses 9106 9112 +6 |
maxcapodi78
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nonethermalmodifierandspatialmodifierproperties, the material was changed properly, but PyAEDT property did not show the change.None(EITHER in the UI or in PyAEDT), further changes in the property modifiers would be ignored.