Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: GeometryModeler.create_air_region() #4978

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

Devin-Crawford
Copy link
Collaborator

This method was operating incorrectly. See issue #4972

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Jul 31, 2024
maxcapodi78
maxcapodi78 previously approved these changes Jul 31, 2024
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.66%. Comparing base (953f428) to head (5027d68).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4978   +/-   ##
=======================================
  Coverage   83.65%   83.66%           
=======================================
  Files         121      121           
  Lines       54793    54793           
=======================================
+ Hits        45838    45843    +5     
+ Misses       8955     8950    -5     

test_02_3D_modeler.py
@Devin-Crawford Devin-Crawford marked this pull request as ready for review August 1, 2024 07:13
@SMoraisAnsys
Copy link
Collaborator

@dcrawforAtAnsys I took the liberty to rerun a job of the CI as it failed because of something from vtk side (URL https://wheels.vtk.org was not reached)

@SMoraisAnsys SMoraisAnsys merged commit 797600b into main Aug 1, 2024
46 checks passed
@SMoraisAnsys SMoraisAnsys deleted the fix/create_region_4972 branch August 1, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants