FEAT: Fields markers #4981
Merged
FEAT: Fields markers #4981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
# Conflicts: # _unittest/test_98_Icepak.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4981 +/- ##
=======================================
Coverage 83.50% 83.50%
=======================================
Files 122 122
Lines 54952 54957 +5
=======================================
+ Hits 45886 45893 +7
+ Misses 9066 9064 -2 |
|
@Samuelopez-ansys @SMoraisAnsys Codecov is not passing as the method works only in graphical mode (bug already reported) |
Samuelopez-ansys
previously approved these changes
Aug 12, 2024
Samuelopez-ansys
previously approved these changes
Aug 12, 2024
There was a problem hiding this comment.
@lorenzovecchietti I left some minor comments to ease future maintenance / readability
Co-authored-by: Sébastien Morais <[email protected]>
Samuelopez-ansys
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.