Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Using excitation type "winding" instead of "winding group" #5006

Merged
merged 16 commits into from
Aug 13, 2024

Conversation

IreneWoyna
Copy link
Contributor

No description provided.

@IreneWoyna IreneWoyna self-assigned this Aug 7, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Aug 7, 2024
@IreneWoyna
Copy link
Contributor Author

@gmalinve Maxwell throws an error and doesn't create a circuit already when I'm calling the method:
wdg_groups = self.excitations_by_type["Winding Group"]
(also when I'm actually not using wdg_groups)

That's why I commented it in the code.

pyaedt/maxwell.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.50%. Comparing base (f572b8a) to head (a26d53d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5006      +/-   ##
==========================================
- Coverage   83.50%   83.50%   -0.01%     
==========================================
  Files         122      122              
  Lines       54952    54961       +9     
==========================================
+ Hits        45886    45893       +7     
- Misses       9066     9068       +2     

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) August 8, 2024 06:35
@gmalinve gmalinve marked this pull request as draft August 8, 2024 07:08
auto-merge was automatically disabled August 8, 2024 07:08

Pull request was converted to draft

@gmalinve gmalinve marked this pull request as ready for review August 8, 2024 12:09
gmalinve
gmalinve previously approved these changes Aug 8, 2024
@Samuelopez-ansys Samuelopez-ansys merged commit d198400 into main Aug 13, 2024
43 of 44 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/external_excitation_type branch August 13, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants