Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Linux licenseclient path #5032

Merged
merged 2 commits into from
Aug 12, 2024
Merged

FIX: Linux licenseclient path #5032

merged 2 commits into from
Aug 12, 2024

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Aug 12, 2024 •
edited
Loading

Close #5029

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Aug 12, 2024
@Samuelopez-ansys Samuelopez-ansys mentioned this pull request Aug 12, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.50%. Comparing base (641d92f) to head (fe1ca55).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5032      +/-   ##
==========================================
- Coverage   83.50%   83.50%   -0.01%     
==========================================
  Files         122      122              
  Lines       54952    54952              
==========================================
- Hits        45886    45885       -1     
- Misses       9066     9067       +1

SMoraisAnsys
SMoraisAnsys approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a minor comment as linx64 seems to close to linux64 for not using the latter.

pyaedt/generic/general_methods.py Show resolved Hide resolved
@Samuelopez-ansys Samuelopez-ansys merged commit f572b8a into main Aug 12, 2024
44 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/issue_linux_typo branch August 12, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

@gmalinve gmalinve Awaiting requested review from gmalinve

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User Guide mentions analyze_nominal() which does not exist
2 participants
@Samuelopez-ansys @SMoraisAnsys