Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: PyEDB Path class name refactor #5069

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

Samuelopez-ansys
Copy link
Member

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Aug 20, 2024
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) August 20, 2024 09:35
Copy link
Collaborator

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.90%. Comparing base (d5d018c) to head (1c9557f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5069      +/-   ##
==========================================
+ Coverage   78.74%   82.90%   +4.16%     
==========================================
  Files         124      124              
  Lines       55510    55506       -4     
==========================================
+ Hits        43712    46020    +2308     
+ Misses      11798     9486    -2312     

@Samuelopez-ansys Samuelopez-ansys merged commit f8addba into main Aug 20, 2024
42 of 43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/pyedb_class_name_refactor branch August 20, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants