Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST: Improve touchstone parser coverage #5349

Merged
merged 6 commits into from
Nov 5, 2024
Merged

TEST: Improve touchstone parser coverage #5349

merged 6 commits into from
Nov 5, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Oct 28, 2024 •
edited
Loading

PR changes:

  • refactoring of touchstoner_parser.py to add logging instead of print and remove # pragma: no cover
  • improve test coverage by using patches and mocks.

Close #5347

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the testing Anything related to testing label Oct 28, 2024
@SMoraisAnsys SMoraisAnsys changed the title TESTS: Improve touchstone parser coverage TEST: Improve touchstone parser coverage Oct 28, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.38%. Comparing base (ea34abc) to head (d6b9ae7).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5349      +/-   ##
==========================================
+ Coverage   84.36%   84.38%   +0.02%     
==========================================
  Files         140      140              
  Lines       58451    58455       +4     
==========================================
+ Hits        49312    49328      +16     
+ Misses       9139     9127      -12

@SMoraisAnsys SMoraisAnsys self-assigned this Oct 28, 2024
Samuelopez-ansys
Samuelopez-ansys approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Samuelopez-ansys
Samuelopez-ansys previously approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

MaxJPRey
MaxJPRey previously approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SMoraisAnsys for taking the time to add all those tests.

hui-zhou-a
hui-zhou-a reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! LGTM

@SMoraisAnsys
TEST: Update integration tests
f5f7a50 
This changes allow the tests to run without matplotlib
being installed as a dependency.
@SMoraisAnsys SMoraisAnsys merged commit 3c8503b into main Nov 5, 2024
42 checks passed
@SMoraisAnsys SMoraisAnsys deleted the tests/improve-touchstone-parser-coverage branch November 5, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hui-zhou-a hui-zhou-a hui-zhou-a left review comments

@MaxJPRey MaxJPRey MaxJPRey left review comments

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys left review comments

Assignees

@SMoraisAnsys SMoraisAnsys

Labels
testing Anything related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing tests on touchstone parser
4 participants
@SMoraisAnsys @hui-zhou-a @Samuelopez-ansys @MaxJPRey