Restrict protobof<4 #1107
Merged
Restrict protobof<4 #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1107 +/- ##
==========================================
+ Coverage 85.12% 87.48% +2.35%
==========================================
Files 81 81
Lines 9185 9178 -7
==========================================
+ Hits 7819 8029 +210
+ Misses 1366 1149 -217 |
anslpa
approved these changes
Aug 8, 2023
cbellot000
approved these changes
Aug 8, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lastest failures in the CI have been attributed to
ansys-api-plaftorm-instancemanagement==1.0.0b4because it removed the pin onprotobuf<4.Also,
ansys-platform-instancemanagement==1.0.2was pinned inrequirements_test.txtbut not to the latest.This PR updates to
ansys-platform-instancemanagement==1.1.1and tests if forcingansys-api-plaftorm-instancemanagement==1.0.0b3temporarily solves our issues.When using all latest pypim libraries and forcing
protobuf<4: it passes