Update generated code for DPF 241 on master #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #1175 +/- ##
==========================================
- Coverage 87.44% 87.35% -0.09%
==========================================
Files 81 81
Lines 9224 9224
==========================================
- Hits 8066 8058 -8
- Misses 1158 1166 +8 |
github-actions
bot
force-pushed
the
maint/update_code_for_241_on_master
branch
from
ef9b6db
to
51f1e0a
Compare
rafacanton
approved these changes
Oct 9, 2023
PProfizi
reviewed
Oct 9, 2023
| document="""If this pin is set to true, reduced | ||
| coordinates are computed on the | ||
| quadratic element if the element is | ||
| quadratic (default is false).""", | ||
| quadratic (more precise but less | ||
| performant). default is false.""", |
There was a problem hiding this comment.
Hey @rafacanton, a small typo here, should be Default is false.
Do you know who made this change?
PProfizi
reviewed
Oct 9, 2023
|
|
||
| @property | ||
| def field_offset_type(self): | ||
| """Allows to get field_offset_type output of the operator |
There was a problem hiding this comment.
Missing a dot at the end of the sentence.
PProfizi
reviewed
Oct 9, 2023
| @@ -18,6 +18,11 @@ class skin(Operator): | |||
| ---------- | |||
| mesh : MeshedRegion | |||
| mesh_scoping : Scoping, optional | |||
| Nodal scoping to restrict the skin extraction | |||
| to a set of nodes. if provided, a | |||
PProfizi
reviewed
Oct 9, 2023
| @@ -4,7 +4,6 @@ | |||
| from .datasources_provider import datasources_provider | |||
| from .integrate_over_time_freq import integrate_over_time_freq | |||
| from .is_cyclic import is_cyclic | |||
| from .material_provider import material_provider | |||
There was a problem hiding this comment.
@rafacanton Do we know why this is removed? This seems like a potential source of retro-compatibility issue.
There was a problem hiding this comment.
@PProfizi This is the main objective of this update. This operator returns a materials object, which is not well exposed in pydpf-core. The objective of the work done by @MichaelNale was to make this operator private until we do that development, if ever done.
PProfizi
reviewed
Oct 9, 2023
| temperature) and derivative order | ||
| ("derivative_order" label, 0 for | ||
| stiffness terms, 1 for damping terms | ||
| and 2 for inertial terms). default is |
PProfizi
reviewed
Oct 9, 2023
|
|
||
| @property | ||
| def data_sources(self): | ||
| """Allows to get data_sources output of the operator |
PProfizi
reviewed
Oct 9, 2023
| forwards named inputs and outputs | ||
| names, 7 copies connections of named | ||
| inputs and ouputs with their data. | ||
| default is 7. |
PProfizi
reviewed
Oct 9, 2023
| forwards named inputs and outputs | ||
| names, 7 copies connections of named | ||
| inputs and ouputs with their data. | ||
| default is 7.""", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update of generated code has been triggered either manually or by an update in the dpf-standalone repository.