Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update_virtual_environment_for_custom_operators #1632

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

PProfizi
Copy link
Contributor

Issue with new setuptools behavior which creates a __editable__.ansys_dpf_core-****.pth instead of ansys.dpf.core.pth in the interpreter's site-packages when installing in editable mode.
Also fixed the discovery of any original dpf-sites.zip.

@PProfizi PProfizi added the bug Something isn't working label Jun 24, 2024
@PProfizi PProfizi added this to the v0.12.3 milestone Jun 24, 2024
@PProfizi PProfizi self-assigned this Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.91%. Comparing base (ec06e9e) to head (d6c1e56).
Report is 7 commits behind head on master.

Current head d6c1e56 differs from pull request most recent head 9f72bc5

Please upload reports for the commit 9f72bc5 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1632      +/-   ##
==========================================
- Coverage   82.20%   79.91%   -2.30%     
==========================================
  Files          83       83              
  Lines        9855     9866      +11     
==========================================
- Hits         8101     7884     -217     
- Misses       1754     1982     +228     

Signed-off-by: paul.profizi <[email protected]>
@PProfizi PProfizi merged commit 03c64e9 into master Jun 24, 2024
43 checks passed
@PProfizi PProfizi deleted the fix/custom_operator_site_packages_update_on_editable branch June 24, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants