Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a test due to changes on eCONTA174 (consider as linear/quadratic instead of semi parabolic) #1746

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

MichaelNale
Copy link
Contributor

Change server side the eleType related to eCONTA174. We used to consider it as semi parabolic if he was surrounded by linear elements and that lead to inconsistency (for example to compute element::volume). Now, regarding this, we linearize this element or keep it quadratic.

@rafacanton
Copy link
Contributor

@MichaelNale I guess that when the changes are ported to core, you will create a new test that tests these functionalities, right?

@MichaelNale
Copy link
Contributor Author

@rafacanton At the end I can just update to reflect the fact that these elements are not semi parabolic anymore. Here it will be just assert dpf.core.element_types.descriptor(el.type).n_nodes = len(el.connectivity).

@rafacanton
Copy link
Contributor

@rafacanton At the end I can just update to reflect the fact that these elements are not semi parabolic anymore. Here it will be just assert dpf.core.element_types.descriptor(el.type).n_nodes = len(el.connectivity).

I was referring to the opposite. Instead of changing this test to ensure that this element is no longer semiparabolic, you can also find a proper semiparabolic element in another model and test the same assertion (and that way you are still covering the scenario of this test!)

@MichaelNale MichaelNale merged commit 9401cf5 into master Sep 24, 2024
43 checks passed
@MichaelNale MichaelNale deleted the mnale/bugs/25.1/element__volume_tests branch September 24, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants