Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to use core.make_tmp_dir_server #936

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented May 5, 2023

make_tmp_dir_server has recently been fixed to actually create the folder if it does not already exist.

@PProfizi PProfizi requested a review from anslpa May 5, 2023 11:34
@PProfizi PProfizi self-assigned this May 5, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #936 (1835348) into master (8917810) will increase coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
+ Coverage   88.22%   88.61%   +0.39%     
==========================================
  Files          73       73              
  Lines        8356     8356              
==========================================
+ Hits         7372     7405      +33     
+ Misses        984      951      -33     

@PProfizi PProfizi added this to the v0.8.2 milestone May 11, 2023
@PProfizi PProfizi merged commit f93c2f4 into master Jul 17, 2023
@PProfizi PProfizi deleted the fix/make_tmp_dir branch July 17, 2023 08:44
@PProfizi PProfizi added the examples Related to PyDPF-Core examples label Aug 2, 2023
@germa89
Copy link
Contributor

germa89 commented Aug 7, 2023

I think dpf.core.make_tmp_dir_server(dpf.SERVER) line is a bit redundant, since if you are on local you should not needed (part of the logic), and if you are on remote, you should create it automatically (if needed) and the file server path if you needed it it is returned when you uploaded.

In PyMAPDL CICD that line is required to initialize dpf.SERVER otherwise it is None. This makes this line redundant or not very useful. Please notice we rely on the legacy grpc server because we use a DPF docker image.
I will see if I can update it these days. Any advice is welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Related to PyDPF-Core examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants