Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: layout #649

Merged
merged 23 commits into from
Jul 10, 2024
Merged

REFACTOR: layout #649

merged 23 commits into from
Jul 10, 2024

Conversation

hui-zhou-a
Copy link
Collaborator

@hui-zhou-a hui-zhou-a commented Jul 8, 2024

  • Separated class Layout from class EDBLayout.
  • Moved/refactored methods from class dotnet.layout.LayoutDotNet into class Layout
  • Deleted redundant file dotnet.layout.py
  • rename EDBLayout to Moderler.
  • changed - one py file only has one class.
    • This is due to the fact that there are many levels of inheritance, which leads to single file too big. Small classes of cause can be put in one file.
    • Circular import can be avoided if import is done appropriately.
  • Moved BuildSimulationConfiguration unittest into a separate file.
  • Removed many redundant properties. These properties should be inherit from parent class.

Properties of Layout returns pyedb classes. These properties should be reused as much as possible. There are methods in class Modeler are dealing with EDB API classes. These methods should be refactored in a separate PR.

@hui-zhou-a hui-zhou-a changed the title REFACTOR: layout REFACTOR: layout part 1 Jul 8, 2024
@svandenb-dev svandenb-dev self-requested a review July 8, 2024 19:10
@hui-zhou-a hui-zhou-a changed the title REFACTOR: layout part 1 REFACTOR: layout Jul 9, 2024
@hui-zhou-a hui-zhou-a marked this pull request as draft July 9, 2024 13:12
@hui-zhou-a hui-zhou-a linked an issue Jul 10, 2024 that may be closed by this pull request
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hui-zhou-a hui-zhou-a merged commit 7968d1e into main Jul 10, 2024
25 checks passed
@hui-zhou-a hui-zhou-a deleted the 3d-comp-layout branch July 10, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor - Layout class
2 participants