Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Extend ref pin search outside component with create port on component #650

Conversation

svandenb-dev
Copy link
Collaborator

No description provided.

svandenb-dev and others added 3 commits July 8, 2024 14:14
…mponent-with-create-port-on-component' into extend-ref-pin-search-outside-component-with-create-port-on-component
hui-zhou-a
hui-zhou-a previously approved these changes Jul 9, 2024
Copy link
Collaborator

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments.

src/pyedb/dotnet/edb_core/components.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb_core/components.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb_core/components.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb_core/components.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb_core/components.py Show resolved Hide resolved
src/pyedb/dotnet/edb_core/components.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb_core/components.py Show resolved Hide resolved
src/pyedb/dotnet/edb_core/components.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb_core/components.py Outdated Show resolved Hide resolved
…mponent-with-create-port-on-component' into extend-ref-pin-search-outside-component-with-create-port-on-component
SMoraisAnsys
SMoraisAnsys previously approved these changes Jul 9, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I found a last typo though

src/pyedb/dotnet/edb_core/components.py Outdated Show resolved Hide resolved
@svandenb-dev svandenb-dev merged commit 98c238a into main Jul 9, 2024
25 checks passed
@svandenb-dev svandenb-dev deleted the extend-ref-pin-search-outside-component-with-create-port-on-component branch July 9, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Create port from SimulationConfiguration fails when no reference pins are in components.
3 participants