-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Extend ref pin search outside component with create port on component #650
FIX: Extend ref pin search outside component with create port on component #650
Conversation
# Conflicts: # src/pyedb/dotnet/edb_core/edb_data/hfss_pi_simulation_setup_data.py # src/pyedb/dotnet/edb_core/utilities/simulation_setup.py
…-create-port-on-component
…mponent-with-create-port-on-component' into extend-ref-pin-search-outside-component-with-create-port-on-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of comments.
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
For more information, see https://pre-commit.ci
…-create-port-on-component
…mponent-with-create-port-on-component' into extend-ref-pin-search-outside-component-with-create-port-on-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I found a last typo though
Co-authored-by: Sébastien Morais <[email protected]>
No description provided.