REFACTOR: removed is_ironpython and inside_desktop variables as it is not anymore #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re supported in pyedb
For more information, see https://pre-commit.ci
added 2 commits
July 11, 2024 09:01
…re supported in pyedb
…ronpython # Conflicts: # src/pyedb/misc/downloads.py
There was a problem hiding this comment.
@maxcapodi78 Don't we have to keep compatibility for the time being as pyaedt is still IronPython compatible ? This should be changed pretty soon though.
…re supported in pyedb
@SMoraisAnsys no because Ironpython in AEDT doesn't have pip support, so it's already excluded from actual support |
hui-zhou-a
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.