Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: EDB Configuration support in SIwave #709

Merged
merged 8 commits into from
Aug 7, 2024
Merged

Conversation

hui-zhou-a
Copy link
Collaborator

No description provided.

@hui-zhou-a hui-zhou-a linked an issue Aug 5, 2024 that may be closed by this pull request
@hui-zhou-a
Copy link
Collaborator Author

CI failure due to bug actions/upload-artifact#591

@SMoraisAnsys
Copy link
Collaborator

Updating the branch after main fix

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left minor changes (refactoring and fixing typo)

src/pyedb/siwave.py Outdated Show resolved Hide resolved
src/pyedb/siwave.py Outdated Show resolved Hide resolved
src/pyedb/siwave.py Outdated Show resolved Hide resolved
src/pyedb/siwave.py Outdated Show resolved Hide resolved
hui-zhou-a and others added 4 commits August 7, 2024 10:51
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
@hui-zhou-a
Copy link
Collaborator Author

@SMoraisAnsys thanks for the comments

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SMoraisAnsys SMoraisAnsys merged commit 29b4b1a into main Aug 7, 2024
25 checks passed
@SMoraisAnsys SMoraisAnsys deleted the FEAT-siwave-export-edb branch August 7, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add edb configuration support for SIwave
2 participants