Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Edb cfg export cutout #735

Merged
merged 11 commits into from
Aug 22, 2024
Merged

FEAT: Edb cfg export cutout #735

merged 11 commits into from
Aug 22, 2024

Conversation

hui-zhou-a
Copy link
Collaborator

@hui-zhou-a hui-zhou-a commented Aug 21, 2024

  • export cutout to json
  • new method edb.layout.find_primitive
  • separate test for edb.layout

@hui-zhou-a hui-zhou-a changed the title Edb cfg export cutout FEAT: Edb cfg export cutout Aug 21, 2024
svandenb-dev
svandenb-dev previously approved these changes Aug 21, 2024
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/pyedb/dotnet/edb_core/cell/layout.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb_core/cell/layout.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb_core/cell/layout.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb_core/cell/layout.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb_core/cell/layout.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb_core/cell/layout.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb_core/cell/layout.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb_core/cell/layout.py Outdated Show resolved Hide resolved
@hui-zhou-a
Copy link
Collaborator Author

@svandenb-dev I updated the code according to your comments. Please add your comments as one review comment next time.

svandenb-dev
svandenb-dev previously approved these changes Aug 21, 2024
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 5d3079c into main Aug 22, 2024
25 checks passed
@svandenb-dev svandenb-dev deleted the edb-cfg-export-cutout branch August 22, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants