Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: edb configuration padstack #784

Merged
merged 6 commits into from
Sep 12, 2024
Merged

FEAT: edb configuration padstack #784

merged 6 commits into from
Sep 12, 2024

Conversation

hui-zhou-a
Copy link
Collaborator

@hui-zhou-a hui-zhou-a commented Sep 12, 2024 •
edited
Loading

  • Add padstack definition import/export per layer capability in edb configuration
  • Add workaround to handle antipad and thermal pad missing bug in .net api.
  • Add properties pad_parameters and hole_parameters
  • Add set_properties and get_properties to padstack definition
  • Methods to convert PascalCase to snake_case, snake_case to PascalCase

This was linked to issues Sep 12, 2024
(AO) edb.stackup.load(stackup_file, rename=True) makes ignore original Anti PAD definition in VIA padstack #785
Closed
Add feature to edb configuration #786
Closed
@hui-zhou-a hui-zhou-a changed the title Feat: cfg padstack FEAT: edb configuration padstack Sep 12, 2024
@hui-zhou-a hui-zhou-a linked an issue Sep 12, 2024 that may be closed by this pull request
Add method to convert pascal to PascalCase to snake_case vice versa #787
Closed
svandenb-dev
svandenb-dev approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hui-zhou-a hui-zhou-a merged commit e9361f1 into main Sep 12, 2024
25 checks passed
@hui-zhou-a hui-zhou-a deleted the feat-cfg-padstack branch September 12, 2024 13:40
@aohta2021
Copy link

I test its code.
However, fix_padstack_def is not considered.
:edbapp.configuration.run(fix_padstack_def=True)

Traceback (most recent call last):
File "C:\Users\aohta\OneDrive - ANSYS, Inc\Documents\2024_BMT\Sony\Auto\TEST_0905\pyedb_set_layer_model.py", line 71, in
edbapp.configuration.run(fix_padstack_def=True)
TypeError: Configuration.run() got an unexpected keyword argument 'fix_padstack_def'

@hui-zhou-a hui-zhou-a added the good first issue Easy to solve for newcomers label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svandenb-dev svandenb-dev svandenb-dev approved these changes

@SMoraisAnsys SMoraisAnsys Awaiting requested review from SMoraisAnsys

Assignees
No one assigned
Labels
good first issue Easy to solve for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@hui-zhou-a @aohta2021 @svandenb-dev