Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: EDB Config - export component properties #810

Merged
merged 9 commits into from
Sep 24, 2024
Merged

FEAT: EDB Config - export component properties #810

merged 9 commits into from
Sep 24, 2024

Conversation

hui-zhou-a
Copy link
Collaborator

No description provided.

@hui-zhou-a hui-zhou-a changed the title feat: export component properties FEAT: EDB Config - export component properties Sep 23, 2024
@hui-zhou-a hui-zhou-a marked this pull request as ready for review September 23, 2024 12:14
@hui-zhou-a hui-zhou-a added the grpc-transition Changes that need to be included in gRPC transition label Sep 23, 2024
SMoraisAnsys
SMoraisAnsys reviewed Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the method added to components by made into python properties instead of get/set calls ? Btw, is there a reason to remove the classes CfgXXXProperties ?

@hui-zhou-a
Copy link
Collaborator Author

Could the method added to components by made into python properties instead of get/set calls ? Btw, is there a reason to remove the classes CfgXXXProperties ?
get/set is replaced by property in the coming commit.

I do not find the value of CfgXXXProperties. The less the better. I will bring them back when we need them.

ring630 and others added 5 commits September 23, 2024 18:08
Update CfgBoundary class
40e5fca
@pre-commit-ci
MISC: Auto fixes from pre-commit.com hooks
e3db802 
For more information, see https://pre-commit.ci
minor fix
b91a739
Merge remote-tracking branch 'origin/edb-cfg-component-export' into e…
889d8e6 
…db-cfg-component-export

# Conflicts:
#	src/pyedb/configuration/cfg_boundaries.py
#	src/pyedb/dotnet/edb_core/edb_data/hfss_extent_info.py
@pre-commit-ci
MISC: Auto fixes from pre-commit.com hooks
233e0be 
For more information, see https://pre-commit.ci
svandenb-dev
svandenb-dev approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

svandenb-dev
svandenb-dev approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hui-zhou-a hui-zhou-a merged commit 5567b2f into main Sep 24, 2024
27 checks passed
@hui-zhou-a hui-zhou-a deleted the edb-cfg-component-export branch September 24, 2024 09:09
@hui-zhou-a hui-zhou-a linked an issue Sep 24, 2024 that may be closed by this pull request
Bug located in EDB Configuration 2.0 ToolKit #813
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMoraisAnsys SMoraisAnsys SMoraisAnsys left review comments

@svandenb-dev svandenb-dev svandenb-dev approved these changes

Assignees
No one assigned
Labels
grpc-transition Changes that need to be included in gRPC transition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug located in EDB Configuration 2.0 ToolKit
3 participants
@hui-zhou-a @svandenb-dev @SMoraisAnsys