fix: dir() over ArgumentWrapper. #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prmukherj
requested review from
mkundu1,
seanpearsonuk and
hpohekar
as code owners
prmukherj
commented
Sep 26, 2024
mkundu1
reviewed
Sep 27, 2024
prmukherj
commented
Sep 27, 2024
mkundu1
approved these changes
Sep 27, 2024
hpohekar
approved these changes
Sep 27, 2024
seanpearsonuk
approved these changes
Sep 30, 2024
prmukherj
added a commit
that referenced
this pull request
Oct 9, 2024
* fix: dir() over ArgumentWrapper. * Update test. * Update dir() of arg. * Fix fluent side bug. * update test marker. * Update src/ansys/fluent/core/workflow.py * Update logic. * remove docstring.
prmukherj
added a commit
that referenced
this pull request
Oct 10, 2024
* fix: add missing methods (#3323) add missing methods * fix: Handle file-list in datamodel for file-transfer service. (#3343) * fix: dir() over ArgumentWrapper. (#3321) * fix: dir() over ArgumentWrapper. * Update test. * Update dir() of arg. * Fix fluent side bug. * update test marker. * Update src/ansys/fluent/core/workflow.py * Update logic. * remove docstring. * fix: Add missing event_type argument to BaseSession._build_from_fluent_connection (#3349) * fix: Update LocalFileTransferStrategy (#3353) * fix: Update LocalFileTransferStrategy * fix: Update PIMLauncher * refactoring * fix: Update arguments behaviour. (#3332) * fix: Update arguments behaviour. * Minor fix. * Update behaviour. * Fix 'update_dict' w.r.t. server. * fix: se dir fn (#3367) * filtered dir * filtered dir * change to function object approach * filtered dir * filtered dir * change to function object approach * rm temp code --------- Co-authored-by: Mainak Kundu <[email protected]> * fix: Remove unimplemented iteration started event (#3368) * fix: meshng wf update (#3356) * meshng wf update * tests * meshng wf update * tests * Clean up. * meshng wf update * tests * Clean up. --------- Co-authored-by: Prithwish Mukherjee <[email protected]> Co-authored-by: Prithwish Mukherjee <[email protected]> * build: Bump version to v0.26.1 * Remove docformatter from ci. * Skip tests for patch. --------- Co-authored-by: Sean Pearson <[email protected]> Co-authored-by: Mainak Kundu <[email protected]> Co-authored-by: Harshal Pohekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In enhanced meshing it is possible to call
fault_tolerant.describe_geometry_and_flow.flow_type.allowed_values(), but ifdir(fault_tolerant.describe_geometry_and_flow.flow_type)is run 'allowed_values' isn't listed (nor are 'default_value', 'is_active', etc).The dir() method over ArgumentWrapper is corrected.