Changing deprecated PyVista function

[clatapie]

Closes #209.

[clatapie]

The rst.py file seems to have more deprecated PyVista functions that initially expected. For example, plotter.camera_position is not documented in the PyVista documentation.
I ping @AlejandroFernandezLuces to get his opinion on it.

[AlejandroFernandezLuces]

Your changes look fine, but reviewing the whole file I've found some functions that are not using the appropiate methods. I'll point out the methods I find that I think can be substituted by better options

[AlejandroFernandezLuces]

I think we can change plotter.textActor.SetText for plotter.add_text in this occurrences. If there is a reason why we are using the VTK functionality instead of the add_text wrapper let me know.
https://github.com/pyansys/pymapdl-reader/blob/cdc665de56bedf659911e29874c396e7b3a97cdd/ansys/mapdl/reader/rst.py#L3122-L3128

https://github.com/pyansys/pymapdl-reader/blob/cdc665de56bedf659911e29874c396e7b3a97cdd/ansys/mapdl/reader/rst.py#L3337

[AlejandroFernandezLuces]

Not deprecated, but I would change the background of the plotter using the theme as you did with the text, just to keep the code consistent. Not mandatory, up to you 😄

https://github.com/pyansys/pymapdl-reader/blob/cdc665de56bedf659911e29874c396e7b3a97cdd/ansys/mapdl/reader/rst.py#L3023-L3024

https://docs.pyvista.org/api/plotting/_autosummary/pyvista.themes.DefaultTheme.html

[AlejandroFernandezLuces]

Same with NaN color, I would use the theme
https://github.com/pyansys/pymapdl-reader/blob/cdc665de56bedf659911e29874c396e7b3a97cdd/ansys/mapdl/reader/rst.py#L3044
https://docs.pyvista.org/api/plotting/_autosummary/pyvista.themes.DefaultTheme.nan_color.html#pyvista.themes.DefaultTheme.nan_color

[AlejandroFernandezLuces]

The rst.py file seems to have more deprecated PyVista functions that initially expected. For example, plotter.camera_position is not documented in the PyVista documentation. I ping @AlejandroFernandezLuces to get his opinion on it.

camera_position is documented in PyVista docs, maybe you didn't find it because it is in BasePlotter, from which Plotter inherits:
https://docs.pyvista.org/api/plotting/_autosummary/pyvista.BasePlotter.camera_position.html#camera-position

FYI, the planar views and the isometric view are implemented in PyVista, just in case you are modifying manually the camera position for this.

[AlejandroFernandezLuces]

Remove commented out code:

https://github.com/pyansys/pymapdl-reader/blob/cdc665de56bedf659911e29874c396e7b3a97cdd/ansys/mapdl/reader/rst.py#L3272-L3274

[AlejandroFernandezLuces]

Same as before, use theme if possible:

https://github.com/pyansys/pymapdl-reader/blob/cdc665de56bedf659911e29874c396e7b3a97cdd/ansys/mapdl/reader/rst.py#L3287

[AlejandroFernandezLuces]

Substitute for plotter.add_text if possible

https://github.com/pyansys/pymapdl-reader/blob/cdc665de56bedf659911e29874c396e7b3a97cdd/ansys/mapdl/reader/rst.py#L3335-L3337

[AlejandroFernandezLuces]

Isn't there a [email protected] email or something alike? Maybe we should remove @akaszynski email from here 😄

https://github.com/pyansys/pymapdl-reader/blob/cdc665de56bedf659911e29874c396e7b3a97cdd/ansys/mapdl/reader/rst.py#L62-L65

[RobPasMue]

Isn't there a [email protected] email or something alike? Maybe we should remove @akaszynski email from here 😄

https://github.com/pyansys/pymapdl-reader/blob/cdc665de56bedf659911e29874c396e7b3a97cdd/ansys/mapdl/reader/rst.py#L62-L65

Use [email protected]

[AlejandroFernandezLuces]

LGTM

[germa89]

Thank you guys... I'm going to do a release then.

[RobPasMue]

Wait @germa89 - I wanted to do it with @clatapie - that way she'll get acquainted with the process. If it's fine with you.

[germa89]

I actually thought the same.... but I didn't want to bother you with something I promised I will show her.

Anyways, it is late... @akaszynski already did it..... https://github.com/pyansys/pymapdl-reader/releases/tag/v0.52.9

[RobPasMue]

Weird... there is no GitHub release...

[germa89]

Yeah... the CICD failed. I'm rerunning

[RobPasMue]

Okay, got it. Thanks @germa89!

[germa89]

My pleasure #WorkingEarly #FromFar hahaha

[germa89]

Running...

https://github.com/pyansys/pymapdl-reader/actions/runs/4130028967

[germa89]

I believe this line:

https://github.com/pyansys/pymapdl-reader/blob/main/setup.py#L105

Should be updated?... Because earlier versions of PyVista won't work with this new release?? @RobPasMue @clatapie @AlejandroFernandezLuces

[AlejandroFernandezLuces]

I believe this line:

https://github.com/pyansys/pymapdl-reader/blob/main/setup.py#L105

Should be updated?... Because earlier versions of PyVista won't work with this new release?? @RobPasMue @clatapie @AlejandroFernandezLuces

Definetly yes, parse_color was removed in 0.38.0. I would go for 0.38.1 as minimum dependency, as there were some bugs fixed in that version.