Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing multiversion docs #277

Closed
wants to merge 31 commits into from
Closed

Implementing multiversion docs #277

wants to merge 31 commits into from

Conversation

clatapie
Copy link
Contributor

Closes #276.

@clatapie clatapie requested a review from RobPasMue June 29, 2023 14:28
@clatapie clatapie self-assigned this Jun 29, 2023
@clatapie clatapie linked an issue Jun 29, 2023 that may be closed by this pull request
Multiversion docs are missing #276
Closed
RobPasMue
RobPasMue requested changes Jun 29, 2023
View reviewed changes
ansys/mapdl/reader/__init__.py Outdated Show resolved Hide resolved
doc/source/conf.py Show resolved Hide resolved
doc/source/conf.py Show resolved Hide resolved
@clatapie @RobPasMue
Update doc/source/conf.py
a48c493 
Co-authored-by: Roberto Pastor Muela <[email protected]>
@RobPasMue
Copy link
Member

Also, @clatapie - implementing Vale might be a burden really... let's just remove it from the workflow

@RobPasMue
Copy link
Member

Also, @clatapie - implementing Vale might be a burden really... let's just remove it from the workflow

It wasn't present before either

@RobPasMue
Copy link
Member

Also... you removed the code-style. That one should still be run. The one that you should remove is the doc-style stage.

@RobPasMue
Copy link
Member

I'm not sure it's a good idea removing the current setup.py: it was doing a lot of different things for compilation of CPython modules + it's not really needed to switch to multiversion docs. Let's try to stay within the scope of the PR. Our GitHub actions work as well with a requirements folder containing requirements_*.txt files.

@RobPasMue
Copy link
Member

Closing in favor of #278

@RobPasMue RobPasMue closed this Jun 30, 2023
@RobPasMue RobPasMue deleted the maint/multiversion_docs branch June 30, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue requested changes

Assignees

@clatapie clatapie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiversion docs are missing
2 participants
@clatapie @RobPasMue