Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parse_coordinate_system #340

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fix parse_coordinate_system #340

merged 2 commits into from
Nov 16, 2023

Conversation

akaszynski
Copy link
Collaborator

Fix Result.parse_coordinate_system such that it correctly returns a dictionary as originally intended. This allows for coordinate systems generated with CSYS (or the default cyclic system 12), to be accessed by index.

@RobPasMue
Copy link
Member

@germa89's out of office for a couple of days (until next week) - since I am no MAPDL expert I will leave it to him. Maybe @mikerife wants to weigh in while he is out and give feedback?

RobPasMue
RobPasMue approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Merging

@RobPasMue RobPasMue merged commit 288d835 into main Nov 16, 2023
14 checks passed
@RobPasMue RobPasMue deleted the fix/coord-sys branch November 16, 2023 11:26
@RobPasMue
Copy link
Member

Merged to get 0.53.0 out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@germa89 germa89 Awaiting requested review from germa89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akaszynski @RobPasMue